[Autocomplete][Turbo] Remove BC layers for methods and parameters - #3186
Merged
Merged
Conversation
carsonbot
added
Autocomplete
Feature
Kocal
force-pushed
the
uncomment-new-parameters-and-methods
branch
5 times, most recently
from
November 22, 2025 15:56
bda8eb8 to
a5cea09
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes backward compatibility (BC) layers for the Turbo and Autocomplete packages as part of the preparation for Symfony UX 3.0. The changes make previously optional method parameters mandatory and remove deprecated interfaces that were used to maintain backward compatibility.
Key Changes:
- Made
$eventSourceOptionsparameter mandatory inTurboStreamListenRendererInterface::renderTurboStreamListen() - Made
getAttributes()andgetGroupBy()methods mandatory inEntityAutocompleterInterface - Removed the
TurboStreamListenRendererWithOptionsInterfacemarker interface
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Turbo/src/Twig/TurboStreamListenRendererInterface.php |
Added mandatory $eventSourceOptions parameter with type hint and PHPDoc |
src/Turbo/src/Twig/TurboStreamListenRendererWithOptionsInterface.php |
Removed deprecated marker interface that extended the base interface |
src/Turbo/src/Twig/TurboRuntime.php |
Removed BC layer checking for TurboStreamListenRendererWithOptionsInterface |
src/Turbo/src/Bridge/Mercure/TurboStreamListenRenderer.php |
Updated implementation to use standard parameter instead of func_get_arg() |
src/Turbo/tests/Twig/TurboRuntimeTest.php |
Updated test mock to use base interface instead of deprecated one |
src/Autocomplete/src/EntityAutocompleterInterface.php |
Uncommented getAttributes() and getGroupBy() method declarations |
src/Autocomplete/src/Form/WrappedEntityTypeAutocompleter.php |
Added getAttributes() implementation and removed BC layer for form option lookup |
src/Autocomplete/src/AutocompleteResultsExecutor.php |
Removed method_exists() checks for getAttributes() and getGroupBy() |
src/Autocomplete/src/Form/BaseEntityAutocompleteType.php |
Added additional_attributes form option with type validation |
src/Turbo/CHANGELOG.md |
Documented removal of BC layer for $eventSourceOptions parameter |
src/Autocomplete/CHANGELOG.md |
Documented removal of BC layers for interface methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kocal
force-pushed
the
uncomment-new-parameters-and-methods
branch
4 times, most recently
from
November 29, 2025 12:57
b90cbcb to
8b579f2
Compare
Kocal
force-pushed
the
uncomment-new-parameters-and-methods
branch
from
November 29, 2025 13:38
8b579f2 to
81b0bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgotten from #2754
EDIT: failing checks PHPStan & Turbo tests will be fixed in #3185