Open
Conversation
carsonbot
added
Bug
karheda
changed the title
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||||||||
Author
|
Hi @Kocal I had to create new PR, because I couldn't change my default branch from 2.x to dropzone-multiple-uploads branch in the previews PR. We can close the preview PR. Now we have to solve 3 failing checks of PHP too. Could you tell me if I have made the changes well? |
added 16 commits
December 1, 2025 12:11
…coverage, and adjust styles.
- Format array declarations for better readability in `controller.ts`. - Correct typos in `CHANGELOG.md`. - Adjust imports for consistency in `vitest.config.mjs`. - Refactor `vitest.setup.js` for improved code structure.
…d UI logic for preview visibility and structure.
… and added button attributes.
…coverage, and adjust styles. # Conflicts: # src/Dropzone/assets/dist/controller.js # src/Dropzone/assets/src/controller.ts # src/Dropzone/assets/test/unit/controller.test.ts # src/Dropzone/assets/test/vitest.setup.js # src/Dropzone/assets/vitest.config.mjs
- Format array declarations for better readability in `controller.ts`. - Correct typos in `CHANGELOG.md`. - Adjust imports for consistency in `vitest.config.mjs`. - Refactor `vitest.setup.js` for improved code structure. # Conflicts: # src/Dropzone/CHANGELOG.md # src/Dropzone/assets/src/controller.ts
… files. # Conflicts: # src/Dropzone/assets/src/controller.ts
…d UI logic for preview visibility and structure. # Conflicts: # src/Dropzone/assets/test/unit/controller.test.ts # src/Dropzone/templates/form_theme.html.twig
… and added button attributes.
- Format array declarations for better readability in `controller.ts`. - Correct typos in `CHANGELOG.md`. - Adjust imports for consistency in `vitest.config.mjs`. - Refactor `vitest.setup.js` for improved code structure.
karheda
force-pushed
the
dropzone-multiple-uploads
branch
from
a204ffc to
d6bf015
Compare
This PR was merged into the 2.x branch. Discussion ---------- Git-ignore config/reference.php | Q | A | -------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Documentation? | no <!-- required for new features, or documentation updates --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Since symfony/symfony#62129, a new file `config/reference.php` can be generated when running tests locally. This file must not be commited. Commits ------- 74fd8da Git-ignore config/reference.php
This PR was merged into the 2.x branch. Discussion ---------- Add E2E tests for Chart.js | Q | A | -------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Documentation? | no <!-- required for new features, or documentation updates --> | Issues | Fix symfony#3018 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 23e88a3 Add E2E tests for Chart.js
This PR was merged into the 2.x branch. Discussion ---------- Add E2E tests for Turbo | Q | A | -------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Documentation? | no <!-- required for new features, or documentation updates --> | Issues | Fix symfony#3027 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 76c87b8 Add E2E tests for Turbo
This PR was merged into the 2.x branch. Discussion ---------- Add E2E tests for CropperJS | Q | A | -------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Documentation? | no <!-- required for new features, or documentation updates --> | Issues | Fix symfony#3019 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 1ac8469 Add E2E tests for CropperJS
…coverage, and adjust styles.
- Format array declarations for better readability in `controller.ts`. - Correct typos in `CHANGELOG.md`. - Adjust imports for consistency in `vitest.config.mjs`. - Refactor `vitest.setup.js` for improved code structure.
…d UI logic for preview visibility and structure.
… and added button attributes.
…coverage, and adjust styles. # Conflicts: # src/Dropzone/assets/dist/controller.js # src/Dropzone/assets/src/controller.ts # src/Dropzone/assets/test/unit/controller.test.ts # src/Dropzone/assets/test/vitest.setup.js # src/Dropzone/assets/vitest.config.mjs
- Format array declarations for better readability in `controller.ts`. - Correct typos in `CHANGELOG.md`. - Adjust imports for consistency in `vitest.config.mjs`. - Refactor `vitest.setup.js` for improved code structure. # Conflicts: # src/Dropzone/CHANGELOG.md # src/Dropzone/assets/src/controller.ts
… files. # Conflicts: # src/Dropzone/assets/src/controller.ts
…d UI logic for preview visibility and structure. # Conflicts: # src/Dropzone/assets/test/unit/controller.test.ts # src/Dropzone/templates/form_theme.html.twig
… and added button attributes.
- Format array declarations for better readability in `controller.ts`. - Correct typos in `CHANGELOG.md`. - Adjust imports for consistency in `vitest.config.mjs`. - Refactor `vitest.setup.js` for improved code structure.
…o dropzone-multiple-uploads
Member
|
Hi, there are still issues with your branch, can you rebase it on the latest 2.x? Thanks |
Kocal
added
Status: Needs Work
carsonbot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.