-
-
Notifications
You must be signed in to change notification settings - Fork 403
[Toolkit][Shadcn] Add DropdownMenu component #3232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
960d31f to
e5f1901
Compare
|
I have also added support for dropdown-menu in button group. /cc @bernard-ng |
7ad8366 to
a18aa60
Compare
|
Hi! I started to look at your work, and thanks you so much for that! However, I find there is too much logic in the
Thanks! |
src/Toolkit/kits/shadcn/dropdown-menu/templates/components/DropdownMenu/Content.html.twig
Outdated
Show resolved
Hide resolved
|
@Kocal How to handle custom styles? Should I import them in the controller or is this something to be handled in user land? |
a18aa60 to
18181ba
Compare
18181ba to
2c87864
Compare
2c87864 to
03e3b3d
Compare
24c82d7 to
70af582
Compare
|
Hey! Sorry for the long delay, but I've been pretty busy with #3299, which added a tons of changes for documentation and code examples. 😅 They are now shared between this repo and https://github.com/symfony/ux.symfony.com I will review your PR when possible, can you apply the changes in the meantime? Thanks! 🙏🏻 |
70af582 to
5ffa433
Compare
|
@Kocal No worries, Hugo. I just rebased but missed out on the changes you pushed. 😬 |
|
Looks like something wrong happened when rebased 😱 Don't worry, I will take it from here, thanks for your contribution :) |
|
@Kocal Thanks. I think I messed up the rebase because I didn't expected new commits in this PR and I force pushed from my side. |
Add DropdownMenu as a component with support for checkboxes, radio group, and dialog. It utilizes the already available components like Kbd and Dialog. The Button Group component is also updated to use the new component.
ref: https://ui.shadcn.com/docs/components/dropdown-menu