Skip to content

Conversation

@daFish
Copy link
Contributor

@daFish daFish commented Dec 12, 2025

Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? yes
Issues Tracked in #3233
License MIT

Add DropdownMenu as a component with support for checkboxes, radio group, and dialog. It utilizes the already available components like Kbd and Dialog. The Button Group component is also updated to use the new component.

ref: https://ui.shadcn.com/docs/components/dropdown-menu

@daFish daFish force-pushed the feat/toolkit-dropdown-component branch from 960d31f to e5f1901 Compare December 12, 2025 18:11
@daFish daFish marked this pull request as ready for review December 12, 2025 18:29
@daFish daFish requested a review from Kocal as a code owner December 12, 2025 18:29
@carsonbot carsonbot added Bug Bug Fix Documentation Improvements or additions to documentation Feature New Feature Toolkit Status: Needs Review Needs to be reviewed labels Dec 12, 2025
@daFish
Copy link
Contributor Author

daFish commented Dec 13, 2025

I have also added support for dropdown-menu in button group.

/cc @bernard-ng

@daFish daFish force-pushed the feat/toolkit-dropdown-component branch 2 times, most recently from 7ad8366 to a18aa60 Compare December 14, 2025 11:22
@Kocal
Copy link
Member

Kocal commented Dec 16, 2025

Hi!

I started to look at your work, and thanks you so much for that!

However, I find there is too much logic in the dropdown_menu_controller.js, and I feel like it could be super-simplified by using these new features:

Thanks!

@Kocal Kocal removed the Bug Bug Fix label Dec 16, 2025
@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Dec 16, 2025
@daFish
Copy link
Contributor Author

daFish commented Dec 16, 2025

@Kocal How to handle custom styles? Should I import them in the controller or is this something to be handled in user land?

@daFish daFish force-pushed the feat/toolkit-dropdown-component branch from a18aa60 to 18181ba Compare December 16, 2025 09:26
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Dec 16, 2025
@daFish daFish force-pushed the feat/toolkit-dropdown-component branch from 18181ba to 2c87864 Compare December 16, 2025 09:28
@daFish daFish force-pushed the feat/toolkit-dropdown-component branch from 2c87864 to 03e3b3d Compare December 16, 2025 09:32
@daFish daFish force-pushed the feat/toolkit-dropdown-component branch 2 times, most recently from 24c82d7 to 70af582 Compare January 13, 2026 12:42
@Kocal
Copy link
Member

Kocal commented Jan 17, 2026

Hey!

Sorry for the long delay, but I've been pretty busy with #3299, which added a tons of changes for documentation and code examples. 😅

They are now shared between this repo and https://github.com/symfony/ux.symfony.com

I will review your PR when possible, can you apply the changes in the meantime?

Thanks! 🙏🏻

@daFish daFish force-pushed the feat/toolkit-dropdown-component branch from 70af582 to 5ffa433 Compare January 17, 2026 21:07
@daFish
Copy link
Contributor Author

daFish commented Jan 17, 2026

@Kocal No worries, Hugo. I just rebased but missed out on the changes you pushed. 😬

@Kocal
Copy link
Member

Kocal commented Jan 24, 2026

Looks like something wrong happened when rebased 😱

Don't worry, I will take it from here, thanks for your contribution :)

@daFish
Copy link
Contributor Author

daFish commented Jan 27, 2026

@Kocal Thanks. I think I messed up the rebase because I didn't expected new commits in this PR and I force pushed from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Feature New Feature Status: Needs Review Needs to be reviewed Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants