[LiveComponent] Fix race condition with inputs being modified during a request#3316
Open
tijnema wants to merge 2 commits intosymfony:2.xfrom
Open
[LiveComponent] Fix race condition with inputs being modified during a request#3316tijnema wants to merge 2 commits intosymfony:2.xfrom
tijnema wants to merge 2 commits intosymfony:2.xfrom
Conversation
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue #2899, sometimes form inputs would be cleared. This appears to be a race condition where the input was not sent to the server, but the server response would override the input if it had been modified between request start and morph, even if the server didn't modify anything.
This fixes the issue by checking if an input value is different between now and the value sent to the server, and will then not update the value from the server. Server side changes are still supported, because the code will automatically send a new request for the changed input.
I tried writing a test for it, but so far couldn't reproduce it with a test