Skip to content

[Toolkit][Shadcn] Update Alert CSS class, add Alert:Action component#3318

Merged
Kocal merged 1 commit intosymfony:2.xfrom
ker0x:fix/shadcn-alert
Jan 31, 2026
Merged

[Toolkit][Shadcn] Update Alert CSS class, add Alert:Action component#3318
Kocal merged 1 commit intosymfony:2.xfrom
ker0x:fix/shadcn-alert

Conversation

@ker0x
Copy link
Contributor

@ker0x ker0x commented Jan 25, 2026

Q A
Bug fix? yes
New feature? yes
Deprecations? no
Documentation? yes
Issues Fix #...
License MIT

This PR update the CSS class of the Alert component according to official Shadcn documentation.

It also add Alert:Action component

@ker0x ker0x requested a review from Kocal as a code owner January 25, 2026 10:09
@carsonbot carsonbot added Bug Bug Fix Documentation Improvements or additions to documentation Feature New Feature Toolkit Status: Needs Review Needs to be reviewed labels Jan 25, 2026
@ker0x ker0x force-pushed the fix/shadcn-alert branch 3 times, most recently from 5f1a045 to 43ffc38 Compare January 25, 2026 10:22
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, can you rebase on latest 2.x please?

@ker0x
Copy link
Contributor Author

ker0x commented Jan 27, 2026

@Kocal It's done!

Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like official examples changed.. again.. 😅

Can you add the following examples:

  • Basic
  • Destructive
  • Action
  • Custom Colors
    and also update the Demo/Usage code?

You will need to open a PR on https://github.com/symfony/ux.symfony.com as well.

Thanks!

@ker0x ker0x force-pushed the fix/shadcn-alert branch 2 times, most recently from 77a4359 to 5984e48 Compare January 30, 2026 09:29
@ker0x
Copy link
Contributor Author

ker0x commented Jan 30, 2026

@Kocal I've updated and rebased the PR! The styles for the Button component have also changed on Shadcn, so I've updated those as well.

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jan 31, 2026
@Kocal
Copy link
Member

Kocal commented Jan 31, 2026

That's perfect, thanks for your hard work @ker0x

@Kocal Kocal merged commit 334a9e5 into symfony:2.x Jan 31, 2026
22 of 26 checks passed
Kocal added a commit to symfony/ux.symfony.com that referenced this pull request Jan 31, 2026
…t (ker0x)

This PR was merged into the main branch.

Discussion
----------

[Toolkit][Shadcn] Update documentation for Alert component

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no
| Issues         | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

Related to symfony/ux#3318

Commits
-------

d52b891 [Toolkit][Shadcn] Update documentation for Alert component
@ker0x ker0x deleted the fix/shadcn-alert branch January 31, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Bug Fix Documentation Improvements or additions to documentation Feature New Feature Status: Reviewed Has been reviewed by a maintainer Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants