[Shadcn] Add Sonner - #3477
Merged
Merged
[Shadcn] Add Sonner#3477
Conversation
makraz
force-pushed
the
feat/toolkit-toast
branch
from
April 17, 2026 17:59
86ce6ae to
a756085
Compare
makraz
changed the title
makraz
force-pushed
the
feat/toolkit-toast
branch
3 times, most recently
from
April 19, 2026 18:47
d7172da to
1ce0877
Compare
zairigimad
reviewed
Apr 22, 2026
Contributor
|
It will be great to add a video 🙏🏻 |
makraz
added a commit
to makraz/ux
that referenced
this pull request
Jun 27, 2026
Namespace the controller's custom event channel to the recipe name for consistency with data-controller="sonner" and the Twig surface: - window event 'toast' -> 'sonner' (listen + dispatch) - handler onToastEvent -> onSonnerEvent - outbound 'toast:dismiss' -> 'sonner:dismiss' The public toast() helper keeps its name (matches the upstream Sonner API), and the per-item "toast" vocabulary (data-slot, Toast component) is unchanged. Addresses review feedback on symfony#3477.
makraz
added a commit
to makraz/ux
that referenced
this pull request
Jun 27, 2026
Namespace the controller's custom event channel to the recipe name for consistency with data-controller="sonner" and the Twig surface: - window event 'toast' -> 'sonner' (listen + dispatch) - handler onToastEvent -> onSonnerEvent - outbound 'toast:dismiss' -> 'sonner:dismiss' The public toast() helper keeps its name (matches the upstream Sonner API), and the per-item "toast" vocabulary (data-slot, Toast component) is unchanged. Addresses review feedback on symfony#3477.
makraz
force-pushed
the
feat/toolkit-toast
branch
from
June 27, 2026 21:36
25acc69 to
4fbfcc8
Compare
makraz
added a commit
to makraz/ux
that referenced
this pull request
Jun 27, 2026
Namespace the controller's custom event channel to the recipe name for consistency with data-controller="sonner" and the Twig surface: - window event 'toast' -> 'sonner' (listen + dispatch) - handler onToastEvent -> onSonnerEvent - outbound 'toast:dismiss' -> 'sonner:dismiss' The public toast() helper keeps its name (matches the upstream Sonner API), and the per-item "toast" vocabulary (data-slot, Toast component) is unchanged. Addresses review feedback on symfony#3477.
makraz
force-pushed
the
feat/toolkit-toast
branch
from
June 27, 2026 21:42
4fbfcc8 to
d8a95ca
Compare
makraz
added a commit
to makraz/ux
that referenced
this pull request
Jun 27, 2026
Namespace the controller's custom event channel to the recipe name for consistency with data-controller="sonner" and the Twig surface: - window event 'toast' -> 'sonner' (listen + dispatch) - handler onToastEvent -> onSonnerEvent - outbound 'toast:dismiss' -> 'sonner:dismiss' The public toast() helper keeps its name (matches the upstream Sonner API), and the per-item "toast" vocabulary (data-slot, Toast component) is unchanged. Addresses review feedback on symfony#3477.
makraz
force-pushed
the
feat/toolkit-toast
branch
from
June 27, 2026 22:40
d8a95ca to
0ccbffd
Compare
Contributor
Author
@zairigimad here's the video 👌🏼 also created a PR here symfony/ux.symfony.com#151 614241459-2f956a4b-0fd9-4a14-a570-fd049c7ca5e0.mp4 |
Kocal
approved these changes
Jul 5, 2026
carsonbot
added
Status: Reviewed
Member
|
Thank you @makraz. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Sonner component