[Translator] Type and documentation fixes #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
approved these changes
Apr 29, 2023
weaverryan
force-pushed
the
fix/translator-type-and-docs
branch
from
8683709 to
8f472d5
Compare
|
Thanks @Kocal! |
weaverryan
added a commit
that referenced
this pull request
May 1, 2023
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [ux.symfony.com] Add demo page for Translator | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Needs #822 Added interactive demo page for the Translator package, where the user can see the code, the output, and some inputs to play with. https://user-images.githubusercontent.com/2103975/235448398-5cc4e45f-8d5f-475f-8351-c43d57f6a3c7.mov Commits ------- 0e713d2 [ux.symfony.com] Add demo page for Translator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the demo page, I've faced an issue about
Datewhich was unuasable as translation parameter, but it should as we can use it to format date/datetime.The documentation rendering was a bit broken too, I'm not familiar with RST, but it should be fixed.
Also, when running
yarn install, theyarn.lockchange, so I commited it aswell.