Skip to content

[TwigComponent] Html syntax bug test case + fix #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2023

Conversation

weaverryan
Copy link
Member

Q A
Bug fix? yes
New feature? no
Tickets Fix #805
License MIT

Not a fix, just a test case for the bug described in #805. It's probably easy to fix.

This fails to add the correct content block inside of twig:foo:

<twig:foo>
    <twig:bar>bar content</twig:bar>
</twig:foo>

But if you add any non-whitespace character before <twig:bar> - e.g. foo <twig:bar> - then it WILL add the block correctly. So, just some small thing not looking for an embedded component as valid "content" that should open that content block.

@weaverryan weaverryan changed the title [TwigComponent] Html syntax bug test case [TwigComponent] Html syntax bug test case + fix May 1, 2023
@weaverryan
Copy link
Member Author

Now this also has the fix :)

@weaverryan weaverryan force-pushed the twig-html-syntax-test-cases branch from c609746 to 769b55a Compare May 1, 2023 12:34
@weaverryan weaverryan force-pushed the twig-html-syntax-test-cases branch from 769b55a to c3854cc Compare May 1, 2023 12:36
@weaverryan weaverryan merged commit a5fb0bc into symfony:2.x May 1, 2023
@weaverryan weaverryan deleted the twig-html-syntax-test-cases branch May 1, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TwigComponent] Nested component doesn't work with html syntax
1 participant