-
-
Notifications
You must be signed in to change notification settings - Fork 84
include asset again into error pages #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey! Thanks for confirming this - we have a PR for this #21 - we just need to finish it. I think the approach is that we should always call reset when an exception is thrown (via a listener). |
Thank you for this issue. |
Just a quick reminder to make a comment on this. If I don't hear anything I'll close this. |
Seeing that #24 is closed in favor of #71 which has been merged, I think this could be closed as well ? @eschultz-magix @weaverryan what do you think ? |
Symfony version(s) affected: 4.2
Description
The
EntrypointLookup
prevents including a file multiple times by default. But it prevents re-using a stylesheet in an error template if an error occurs during the rendering of a template that re-uses the layout. This is because theExceptionController
will clear the output buffers.How to reproduce
{{ 1 / 0 }}
Possible Solution
The
EntryPointLookup
class must only return a template once per request.The text was updated successfully, but these errors were encountered: