Skip to content

Missing argument 2 (default build name) in webpack_encore.entrypoint_lookup_collection #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weaverryan opened this issue Jun 19, 2019 · 0 comments · Fixed by #71
Closed
Labels
Bug Bug Fix

Comments

@weaverryan
Copy link
Member

For the webpack_encore.entrypoint_lookup_collection service, we're currently NEVER passing the 2nd argument: $defaultBuildName. In WebpackEncoreExtension, we should set this argument to _default inside this if statement:

if (false !== $config['output_path']) {
$factories['_default'] = $this->entrypointFactory($container, '_default', $config['output_path'], $config['cache'], $config['strict_mode']);
$cacheKeys['_default'] = $config['output_path'].'/'.self::ENTRYPOINTS_FILE_NAME;
}

@weaverryan weaverryan added the Bug Bug Fix label Jun 19, 2019
weaverryan added a commit that referenced this issue Jul 1, 2019
…k91)

This PR was merged into the master branch.

Discussion
----------

Autowire defaultBuild argument when it is not disabled

Closes #70

Commits
-------

6dd09de Autowire defaultBuild argument when it is not disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant