Extend from the ResetInterface #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitely a good idea. But, it would mean that the bundle should now require symfony/contracts at version 4.2 I believe. |
|
It already does... http-kernel requires event-dispatcher wich depends on contracts |
|
Ah. But now we have a direct dependency on it - we shouldn’t rely on it indirectly. Also, we will need to specifically require version 4.2 or higher, not just 4.0 or higher (currently, if we don’t explicitly require it in this lib, someone could get 4.1 of everything, which does not rely on contracts). This will also make this bundle work for Symfony 4.2 only (well, at least 4.2 of the contracts library will be required). |
|
Contracts is a standalone package so the bundle will still be compatible with 4.0 |
|
Thank you @fionera! |
weaverryan
added a commit
that referenced
this pull request
Jan 17, 2019
This PR was squashed before being merged into the master branch (closes #27). Discussion ---------- Extend from the ResetInterface This way the Container automaticly resets the returnedFile array and this hack is obsolete php-pm/php-pm-httpkernel#151 Commits ------- 2b244da Add Symfony Contracts Dependency 85f21a0 Extend from the ResetInterface
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the Container automaticly resets the returnedFile array and this hack is obsolete php-pm/php-pm-httpkernel#151