Skip to content

Tests frameworks are outdated #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stof opened this issue May 7, 2020 · 0 comments
Closed

Tests frameworks are outdated #753

stof opened this issue May 7, 2020 · 0 comments

Comments

@stof
Copy link
Member

stof commented May 7, 2020

Package Used version Latest version
chai 3.5.0 4.2.0
chai-fs 1.0.0 2.0.0
mocha 6.2.3 7.1.2
sinon 2.4.1 9.0.2
@stof stof mentioned this issue May 7, 2020
Merged
weaverryan added a commit that referenced this issue May 8, 2020
@weaverryan
minor #754 Upgrade dependencies (stof)
ca61eea 
This PR was squashed before being merged into the master branch.

Discussion
----------

Upgrade dependencies

This upgrades a bunch of dependencies to their latest version.

Things I intentionally kept out of this PR:

- test frameworks (mocha, sinon and chai), as upgrading them is more risky (when I don't touch them, I can rely on the existing testsuite to check the upgrade). These should be handled separately (especially given that they are massively outdated, requiring many major version bumps and so potentially many changes in the tests). See #753
- webpack loaders and plugins, as such upgrades can create BC breaks for Encore itself (and so they deserve separate PRs to test them and make them visible). See #751, #749, #742 for some of them

Commits
-------

dddad18 Upgrade http-server
6704dd0 Upgrade fs-extra
b08417d Upgrade tmp
847e9c7 Upgrade semver
27fc03a Upgrade pkg-up
7dfd592 Upgrade loader-utils
410c7fc Upgrade chalk packages
Kocal added a commit to Kocal/webpack-encore that referenced this issue May 10, 2020
@Kocal
chore(deps-dev): update chai, chai-js, mocha and sinon deps, close sy…
430f6fd 
…mfony#753
Kocal added a commit to Kocal/webpack-encore that referenced this issue May 10, 2020
@Kocal
chore(deps-dev): update chai, chai-js, mocha and sinon deps, close sy…
624484e 
…mfony#753
weaverryan added a commit that referenced this issue May 10, 2020
@weaverryan
minor #764 build(deps-dev): update chai, chai-js, mocha and sinon dep…
b722a0e 
…endencies, close #753 (Kocal)

This PR was merged into the master branch.

Discussion
----------

build(deps-dev): update chai, chai-js, mocha and sinon dependencies, close #753

Commits
-------

f1d1349 build(deps-dev): update chai, chai-js, mocha and sinon deps, close #753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stof