Skip to content

Adapt fonts and images filenames given the useVersioning configu property #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

romainneutron
Copy link

No description provided.

@Lyrkan
Copy link
Collaborator

Lyrkan commented Apr 8, 2020

Hi @romainneutron,

The current behavior is actually intended.

The issue with removing the hash is that if you import two files with the same name from different folders they'll end up overwriting each others during the build.

We also thought about adding the [path] placeholder to prevent that but it also had some cons (such as really ugly paths if you imported an image from your node_modules).

You can check the comments on this PR for more details: #103 (comment)

@romainneutron romainneutron deleted the adapt-path-versioning branch April 9, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants