Skip to content

Added a specified separator param #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added a specified separator param #2

wants to merge 2 commits into from

Conversation

muraken720
Copy link
Contributor

I want to separate each node's values with a specified separator.

@wooorm
Copy link
Member

wooorm commented Oct 31, 2015

Nice work! Two questions:

  1. What's the use case?
  2. You should probably pass 'separator' too when calling 'nlcstToSting' on each 'child'!

@muraken720
Copy link
Contributor Author

  1. I want to create a corpus file which separate each word by white space. So I'm now making a custom compiler for retext and retext-japanese. In Japanese, there is no separator ( A Japanese sentence dose node divide each word ).
  2. That's right. fixed.

@wooorm wooorm closed this in 8ad941b Nov 2, 2015
@wooorm
Copy link
Member

wooorm commented Nov 2, 2015

Thanks!

@muraken720 muraken720 deleted the dev branch November 6, 2015 14:37
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Aug 11, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muraken720 @wooorm