Skip to content

Improve types to base what visitor gets on tree #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2021
Merged

Improve types to base what visitor gets on tree #4

merged 3 commits into from
Jul 30, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Jul 26, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

See syntax-tree/unist-util-visit-parents#10.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 26, 2021
@wooorm wooorm added ☂️ area/types This affects typings 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change and removed 🤞 phase/open Post is being triaged manually labels Jul 26, 2021
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 👍 phase/yes Post is accepted and can be worked on label Jul 26, 2021
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm marked this pull request as ready for review July 30, 2021 08:15
@wooorm wooorm changed the title Add types to narrow what’s given to visitor based on tree Improve types to base what visitor gets on tree Jul 30, 2021
@wooorm wooorm merged commit a45063d into main Jul 30, 2021
@wooorm wooorm deleted the get-nodes-in-tree branch July 30, 2021 08:38
@wooorm wooorm added the 💪 phase/solved Post is done label Jul 30, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 👍 phase/yes Post is accepted and can be worked on label Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wooorm