Specify indent

[wooorm]

node.position.indent isn’t used a lot, but it could be specced better.

Currently, it’s a list of integers, if a node spans multiple lines, where each value refers to the column a line (node.position.start.line + index).
This only supports the start of a line (which is useful in markdown). But not the end of a line.
It’s also awkward to access, as there’s no explicit line access.

It could make sense for indent to be an Array.<{start: Point, end: Point}>.

[wooorm]

No longer needed: remark no longer includes ’em

[unicornware]

@wooorm

for those implementing their own ast, can this be revisited? or can the README be updated to include an example? before finding this issue, i thought indent was (node.position.start.line + node.position.start.column)[]. now i'm not sure if index refers to the index of a new line 😅

[wooorm]

Hm I think it should be removed from the spec instead now that it isn’t used anymore.
You probably shouldn’t need/implement it?

indent is useful for things that span multiple lines, and start at different “columns”. Which can occur in markdown.

So say something spans 3 lines, then position.start is the starting point.
indent[0] is the column of line 2, indent[1] the column of line 3.
I’m not sure if the columns were relative or absolute anymore though, would have to check that.

Problem was, that it should probably be points instead of columns. And why only starts of lines and not ends? 🤷‍♂️