Skip to content

Add types #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2021
Merged

Add types #1

merged 4 commits into from
Feb 22, 2021

Conversation

stefanprobst
Copy link
Contributor

This PR adds types to xast-util-sitemap.

Could probably be improved by making lang required when alternate is present, but i don't know how to do that :/.

The "eslint-disable" comment is because xo suggested to use a stricter Omit from the type-fest package, which is not needed here.

@wooorm
Copy link
Member

wooorm commented Feb 2, 2021

nice! I’ve often added types/ to the xo ignore, because xo is meant more for actual typescript rather than d.ts.

/cc @ChristianMurphy

ChristianMurphy
ChristianMurphy reviewed Feb 2, 2021
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefanprobst!

@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🧑 semver/major This is a change labels Feb 2, 2021
ChristianMurphy
ChristianMurphy approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefanprobst! 🙇

@ChristianMurphy
Copy link
Member

/cc @remcohaszing @Rokt33r

@wooorm wooorm added 🧒 semver/minor This is backwards-compatible change and removed 🧑 semver/major This is a change labels Feb 22, 2021
@wooorm wooorm merged commit 894f22f into syntax-tree:main Feb 22, 2021
@wooorm
Copy link
Member

wooorm commented Feb 22, 2021

Thanks all! Released!

@stefanprobst stefanprobst deleted the types branch February 22, 2021 08:07
This was referenced Mar 12, 2021
Closed
Closed
@ChristianMurphy ChristianMurphy mentioned this pull request Mar 30, 2021
Merged
@wooorm wooorm mentioned this pull request Apr 6, 2021
Closed
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@Rokt33r Rokt33r Rokt33r approved these changes

@Murderlon Murderlon Awaiting requested review from Murderlon

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanprobst @wooorm @ChristianMurphy @Rokt33r