Skip to content

fix(pgsql): keep a client's session state across a poisoned transaction (#6536) - #6537

Open
rahim-kanji wants to merge 11 commits into
feature/pgsql-native-extq-batchingfrom
fix/pgsql-poisoned-txn-session-state-6536
Open

rahim-kanji wants to merge 11 commits into
feature/pgsql-native-extq-batchingfrom
fix/pgsql-poisoned-txn-session-state-6536

test(pgsql): leave hostgroup 1 alone when its snapshot cannot be read

ada903d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Oct 26, 2026 in 13m 33s

Annotations

Check failure on line 917 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 39 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2W&open=AaF5J4qQfbhBxT_0lF2W&pullRequest=6537

Check failure on line 1537 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2e&open=AaF5J4qQfbhBxT_0lF2e&pullRequest=6537

Check failure on line 1254 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 29 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2a&open=AaF5J4qQfbhBxT_0lF2a&pullRequest=6537

Check failure on line 789 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2V&open=AaF5J4qQfbhBxT_0lF2V&pullRequest=6537

Check failure on line 1206 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5VcnEA_wBbPJMo_NJ&open=AaF5VcnEA_wBbPJMo_NJ&pullRequest=6537

Check failure on line 786 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2T&open=AaF5J4qQfbhBxT_0lF2T&pullRequest=6537

Check failure on line 1152 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "std::function" with a template parameter.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2Y&open=AaF5J4qQfbhBxT_0lF2Y&pullRequest=6537

Check failure on line 787 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2U&open=AaF5J4qQfbhBxT_0lF2U&pullRequest=6537

Check failure on line 1182 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 38 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2Z&open=AaF5J4qQfbhBxT_0lF2Z&pullRequest=6537

Check failure on line 392 in lib/PgSQL_ExplicitTxnStateMgr.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5Vc90A_wBbPJMo_NK&open=AaF5Vc90A_wBbPJMo_NK&pullRequest=6537

Check failure on line 1267 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2b&open=AaF5J4qQfbhBxT_0lF2b&pullRequest=6537

Check failure on line 1040 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "std::function" with a template parameter.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2X&open=AaF5J4qQfbhBxT_0lF2X&pullRequest=6537

Check failure on line 776 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 29 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF56WRd6hq09OPoU6ct&open=AaF56WRd6hq09OPoU6ct&pullRequest=6537

Check failure on line 1487 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 53 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2c&open=AaF5J4qQfbhBxT_0lF2c&pullRequest=6537

Check failure on line 1527 in test/tap/tests/pgsql-tx_poisoned_recovery-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J4qQfbhBxT_0lF2d&open=AaF5J4qQfbhBxT_0lF2d&pullRequest=6537

Check failure on line 4224 in lib/PgSQL_Session.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This goto statement must be replaced by a standard iteration statement.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaF5J5KofbhBxT_0lF2f&open=AaF5J5KofbhBxT_0lF2f&pullRequest=6537