Implement LFU as default cache along with memory pool #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
changed the title
jserv
requested changes
Apr 20, 2023
qwe661234
force-pushed
the
wip/LFUcache
branch
2 times, most recently
from
7902397 to
adff200
Compare
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
jserv
reviewed
Apr 20, 2023
We have implemented an adaptive replacement cache to reduce memory usage. However, the complexity of the replacement policy of ARC can lead to a decrease in overall performance. As a result, we implemented the LFU cache, which performed better, but we still retained the ARC for future use. Additionally, we imported the memory pool we developed to limit the memory usage of both caches. The statistics below illustrate the performance of the LFU cache and ARC while running the CoreMark benchmark, indicating that the LFU cache outperforms ARC. | Test | CoreMark(Iterations/Sec) | |------+----------------------------| | ARC | 1123.776 | | LFU | 1155.174 |
|
Thank @qwe661234 for contributing. Let's move forward to JIT compilation. |
2011eric
pushed a commit
to 2011eric/rv32emu
that referenced
this pull request
Jul 22, 2023
An adaptive replacement cache (ARC) was implemented to reduce memory usage. However, the complexity of the replacement policy of ARC can lead to a decrease in overall performance. Therefore, a least frequently used (LFU) cache was also implemented, which outperformed ARC in testing. However, the ARC was retained for future use. In addition, a memory pool was imported to limit the memory usage of both caches. Performance statistics for the LFU cache and ARC running the CoreMark benchmark indicate that the LFU cache outperforms ARC. | Test | CoreMark(Iterations/Sec) | |------+----------------------------| | ARC | 1123.776 | | LFU | 1155.174 |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
An adaptive replacement cache (ARC) was implemented to reduce memory usage. However, the complexity of the replacement policy of ARC can lead to a decrease in overall performance. Therefore, a least frequently used (LFU) cache was also implemented, which outperformed ARC in testing. However, the ARC was retained for future use. In addition, a memory pool was imported to limit the memory usage of both caches. Performance statistics for the LFU cache and ARC running the CoreMark benchmark indicate that the LFU cache outperforms ARC. | Test | CoreMark(Iterations/Sec) | |------+----------------------------| | ARC | 1123.776 | | LFU | 1155.174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have implemented an adaptive replacement cache to reduce memory usage. However, the complexity of the replacement policy of ARC can lead to a decrease in overall performance. As a result, we implemented the LFU cache, which performed better, but we still retained the ARC for future use. Additionally, we imported the memory pool we developed to limit the memory usage of both caches.
The statistics below illustrate the performance of the LFU cache and ARC while running the CoreMark benchmark, indicating that the LFU cache outperforms ARC.