Fix FCVT illegal instruction handling #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing default case in op_op_fp() for FCVT.W.S/FCVT.WU.S to properly reject illegal instruction encodings (rs2 != 0 or 1) - Remove unreachable code after exhaustive switch statements: - op_misc_mem(): return after switch with default case - op_cmisc_alu(): default after all 8 cases (0-7) handled - op_ccr(): default after both cases (0, 1) of single-bit dispatch
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
jserv
commented
Jan 17, 2026
Contributor
Author
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Benchmarks
Details
| Benchmark suite | Current: 82205cb | Previous: 5fe0bcb | Ratio |
|---|---|---|---|
Dhrystone |
1627.667 DMIPS |
1633.333 DMIPS |
1.00 |
CoreMark |
952.707 iterations/sec |
952.119 iterations/sec |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes illegal-instruction handling for FCVT.W.S/FCVT.WU.S and removes unreachable code in several switch statements. This rejects invalid encodings and simplifies control flow.
Bug Fixes
Refactors
Written for commit 82205cb. Summary will update on new commits.