Fix spurious close(fd<3) errors for stripped ELFs #706
+12
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripped ELFs lack symbol tables, so the 'exit' symbol cannot be found and exit_addr remains uninitialized. This caused on_exit to never become true, resulting in spurious error messages when crt0 calls close(0,1,2) during program termination.
Changes:
Summary by cubic
Fix false close(fd<3) errors when running stripped ELFs by properly handling missing exit symbols and avoiding uninitialized exit_addr use. This prevents noisy logs when crt0 closes stdin/stdout/stderr on exit.
Written for commit 674f9d9. Summary will update on new commits.