Trap reserved vfrdiv.vf encoding as illegal-instruction#743
Open
yc199911 wants to merge 1 commit into
Open
Conversation
The reserved encoding (funct6=0x21, funct3=1, OPFVV) was decoded as vfrdiv.vf in op_100001 case 1, executing the FP divide kernel instead of trapping. Per riscv-opcodes, vfrdiv.vf is defined only at funct3=5 (OPFVF). Return false in case 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reserved encoding (funct6=0x21, funct3=1, OPFVV) was decoded
as vfrdiv.vf in op_100001 case 1, executing the FP divide kernel
instead of trapping. Per riscv-opcodes, vfrdiv.vf is defined only
at funct3=5 (OPFVF). Return false in case 1.
Summary by cubic
Fix incorrect decode of reserved
vfrdiv.vfencoding: OPFVV with funct6=0x21, funct3=1 now returns false to trigger an illegal-instruction trap. Per RISC-V V 1.0,vfrdiv.vfis only valid in OPFVF with funct3=5.Written for commit 8656e04. Summary will update on new commits. Review in cubic