Fix vwmaccsu.vx mislabeled as vwmaccus.vx#744
Open
yc199911 wants to merge 1 commit into
Open
Conversation
In op_111111 case 6, funct6=0x3f, funct3=6 was emitting rv_insn_vwmaccus_vx, routing vwmaccsu.vx (signed vector × unsigned scalar) to the vwmaccus_vx executor (unsigned vector × signed scalar). Per riscv-opcodes, funct6=0x3f, funct3=6 is vwmaccsu.vx; the correct executor already exists at rv32_v_template.c:6406. Map case 6 to rv_insn_vwmaccsu_vx.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In op_111111 case 6, funct6=0x3f, funct3=6 was emitting
rv_insn_vwmaccus_vx, routing vwmaccsu.vx (signed vector ×
unsigned scalar) to the vwmaccus_vx executor (unsigned vector ×
signed scalar). Per riscv-opcodes, funct6=0x3f, funct3=6 is
vwmaccsu.vx; the correct executor already exists at
rv32_v_template.c:6406. Map case 6 to rv_insn_vwmaccsu_vx.
Summary by cubic
Fix the vector decoder to route vwmaccsu.vx to the correct executor. op_111111 case 6 (funct6=0x3f, funct3=6) now emits rv_insn_vwmaccsu_vx instead of rv_insn_vwmaccus_vx, restoring signed-vector × unsigned-scalar semantics.
Written for commit 2b8cb48. Summary will update on new commits. Review in cubic