Skip to content
This repository was archived by the owner on Nov 8, 2018. It is now read-only.

Updated to new version of guidelines#359

Merged
medhach merged 1 commit intodevelopfrom
Janiceilene-patch-1
Mar 6, 2018
Merged

Updated to new version of guidelines#359
medhach merged 1 commit intodevelopfrom
Janiceilene-patch-1

Conversation

@janiceilene
Copy link
Copy Markdown
Member

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Fixes # [ISSUE]

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@medhach
Copy link
Copy Markdown

medhach commented Feb 27, 2018

@janiceilene I appreciate your changes, but can you let the previous changes be the same and add your changes to them wherever necessary?
Also, we would really appreciate if you could open an issue and get approval before you start working on it an pull a request. We want to make sure that no two contributors are working on the same issue. :)

@janiceilene
Copy link
Copy Markdown
Member Author

@medhach We're making sweeping changes across all of the repos for consistency and clarity in documentation as part of my Outreachy internship. All of the changes are pre-approved 😄

@medhach medhach requested a review from mayburgos March 1, 2018 17:36
@medhach medhach merged commit 235db36 into develop Mar 6, 2018
@medhach
Copy link
Copy Markdown

medhach commented Mar 6, 2018

@MeepyMay Merging this PR.

@mayburgos mayburgos deleted the Janiceilene-patch-1 branch April 25, 2018 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants