Add Datasources to the Get Command #162
Conversation
|
Thanks for the contribution! Before we can merge this, we need @andyoneal to sign the Salesforce.com Contributor License Agreement. |
|
Code looks good. Can you add an e2e test in the e2e tests file and run it locally? |
|
Done. Tests all passed. |
There was a problem hiding this comment.
=========================== short test summary info
FAILED tests/commands/test_geturl_utils.py::GeturlTests::test_get_workbook_name
E AttributeError: type object 'GetUrl' has no attribute 'get_workbook_name'
tests/commands/test_geturl_utils.py:46: AttributeError
FAILED tests/commands/test_run_commands.py::RunCommandsTest::test_get_workbook
mock_args.url = "/workbooks/workbook-name"
mock_args.filename = "filename.twbx"
get_url_command.GetUrl.run_command(mock_args)
tests/commands/test_run_commands.py:122:
tabcmd/commands/datasources_and_workbooks/get_url_command.py:66: in run_command
Errors.exit_with_error(logger, message=_("tabcmd.get.extension.not_found"))
=================== 2 failed, 184 passed, 1 skipped in 1.00s
jacalata
force-pushed
the
add-get-datasource
branch
from
230ea15 to
011c1ac
Compare
* Add Datasources to the Get Command (#162) * format command-specific help (#203) * hide token-value like we do password * Tfs 1482014 publishing (#205) * make db-auth/oauth mutually exclusive * Create a db credentials item for publishing with --db-username, etc arguments Co-authored-by: Brian Cantoni <[email protected]> Co-authored-by: Bhuvnesh Singh <[email protected]> Co-authored-by: andyoneal <[email protected]>
* add datasources to the get command Co-authored-by: Jac Fitzgerald <[email protected]>
this simply adds datasources as an option for the Get command, in addition to the existing views and workbooks.