Only hash option #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the code to skip the step where files are written to disk if you pass in the --only-hash flag over an http request
alanshaw
requested changes
Sep 8, 2017
test/files.spec.js
Outdated
| const FactoryClient = require('./ipfs-factory/client') | ||
|
|
||
| const testfile = isNode | ||
| ? loadFixture(__dirname, '/fixtures/testfile.txt') | ||
| : loadFixture(__dirname, 'fixtures/testfile.txt') | ||
|
|
||
| // TODO: Test against all algorithms Object.keys(mh.names) | ||
| // This subset is known to work with both go-ipfs and js-ipfs as of 2017-09-05 |
There was a problem hiding this comment.
Please reinstate these above const HASH_ALGS = [
test/files.spec.js
Outdated
| const message = `Failed to get block for ${hash}: context canceled` | ||
| expect(err.message.indexOf(message)).to.be.above(-1) | ||
| }) | ||
| done() |
There was a problem hiding this comment.
Not done until after you attempt to fetch the file
test/files.spec.js
Outdated
|
|
||
| const hash = collected[0].Hash | ||
|
|
||
| ipfs.files.get(hash, (err, res) => { |
There was a problem hiding this comment.
Use ipfs refs local for this.
Rather than use ipfs.get to search for a hash (which should not be there anyway) just use ipfs.refs.local to verify that the hash has not been added to ipfs
Adds promise based tests and uses same method to verify test behaviour
|
262 tests passing (2m) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
--only-hashoption when using the HTTP client