Calamine 0.26.1 generic error

[bq-wrongway]

Just adding calamine to my project results in generic error, pub struct zipfile is missing.

Is there some new requirement? Or some workaround?
In 25.0 it works fine

[AbduEhab]

Same here. Here is the full issue:

error[E0107]: struct takes 1 generic argument but 0 generic arguments were supplied
   --> C:\Users\xxx\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\calamine-0.26.1\src\xlsb\mod.rs:603:18
    |
603 |     r: BufReader<ZipFile<'a>>,
    |                  ^^^^^^^ expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `R`
   --> C:\Users\xxx\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\zip-2.6.1\src\read.rs:252:12
    |
252 | pub struct ZipFile<'a, R: Read> {
    |            ^^^^^^^     -
help: add missing generic argument
    |
603 |     r: BufReader<ZipFile<'a, R>>,
    |                            +++

error[E0107]: struct takes 1 generic argument but 0 generic arguments were supplied
   --> C:\Users\xxx\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\calamine-0.26.1\src\xlsx\mod.rs:26:52
    |
26  | pub(crate) type XlReader<'a> = XmlReader<BufReader<ZipFile<'a>>>;
    |                                                    ^^^^^^^ expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `R`
   --> C:\Users\xxx\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\zip-2.6.1\src\read.rs:252:12
    |
252 | pub struct ZipFile<'a, R: Read> {
    |            ^^^^^^^     -
help: add missing generic argument
    |
26  | pub(crate) type XlReader<'a> = XmlReader<BufReader<ZipFile<'a, R>>>;
    |                                                              +++

error[E0107]: struct takes 1 generic argument but 0 generic arguments were supplied
   --> C:\Users\xxx\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\calamine-0.26.1\src\ods.rs:24:42
    |
24  | type OdsReader<'a> = XmlReader<BufReader<ZipFile<'a>>>;
    |                                          ^^^^^^^ expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `R`
   --> C:\Users\xxx\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\zip-2.6.1\src\read.rs:252:12
    |
252 | pub struct ZipFile<'a, R: Read> {
    |            ^^^^^^^     -
help: add missing generic argument
    |
24  | type OdsReader<'a> = XmlReader<BufReader<ZipFile<'a, R>>>;
    |                                                    +++

For more information about this error, try `rustc --explain E0107`.
error: could not compile `calamine` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...

[jmcnamara]

Same issue as #492

[bowenxuuu]

Add this lib to the [dependencies] section of your Cargo.toml file.

zip = { version = "=2.5.0" }

[bq-wrongway]

I followed this
zip-rs/zip2#332 (comment)
And it solved my issues,this issue as well is duplicate of this

This issue can be closed or marked as duplicate

[simnalamburt]

For those who might be experiencing build issues, here’s a summary of possible workarounds:

1. Temporary solution

For now, doing the following fixes it:

$ cargo update -p zip --precise 2.5.0

But it'll break again if you run cargo update later.

2. Patch dependency version

# Cargo.toml
[patch.crates-io]
zip = { git = "https://github.com/zip-rs/zip2", tag = "v2.5.0" }

Due to a limitation in Cargo (rust-lang/cargo#5478), we unfortunately can’t use the crates.io index when changing dependency versions. As a result, we had to use the git protocol.

3. Patch dependency version (registry)

For those who prefer not to use the git:// protocol:

# Cargo.toml
[patch.crates-io]
zip = { version = "=2.5.0", registry = "crates-io-2" }

# .cargo/config.toml
[registries]
crates-io-2 = { index = "sparse+https://index.crates.io/" }
# Required due to https://github.com/rust-lang/cargo/issues/5478

This can lead to the same sub-dependency being downloaded from both crates-io and crates-io-2. It’s not a major issue to download the same dependency twice, but just be aware of it.

[k-bx]

@tafia how is this completed if calamine still fails with 0.26.1 ?

[tafia]

Version 0.27.0 was published yesterday

[k-bx]

@tafia zip is still bound to 2.5.0. Any plans to allow 2.6 ?

[simnalamburt]

@tafia zip is still bound to 2.5.0. Any plans to allow 2.6 ?

The whole point of calamine 0.27 release is to bound zip to 2.5. See zip-rs/zip2#337 for the further details

[ddimaria]

@tafia please look at this PR from @prophittcorey, it should resolve this problem. zip2 has semver checks installed now, so this should be the last annoyance.