Skip to content

Refactor and simplify #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2015
Merged

Refactor and simplify #9

merged 1 commit into from
Dec 26, 2015

Conversation

colin-kiegel
Copy link
Contributor

I merged the internal buffers enum [] and items [] into one buffer.

This simplifies the macro a bit and should prepare for additional complexity from #5 struct-like-variants.

Note: This PR is based on PR #8, I can rebase / change this one, if the previous one is not ok.

The changes are in the latest commit: 37dcff8

@tailhook
Copy link
Owner

Okay, I've merged in #10, you may now rebase this on top of the current master.

@colin-kiegel
Copy link
Contributor Author

done.

Additionally I made the testcases a bit more stable to upstream changes.

@colin-kiegel
Copy link
Contributor Author

I switched from std::io::Error to the following errors, which implement PartialEq

std::num::ParseFloatError;
std::str::Utf8Error;
std::string::FromUtf8Error;

@colin-kiegel colin-kiegel mentioned this pull request Dec 26, 2015
tailhook added a commit that referenced this pull request Dec 26, 2015
@tailhook tailhook merged commit 0f9e951 into tailhook:master Dec 26, 2015
@tailhook
Copy link
Owner

Looks good. Thanks!

@colin-kiegel colin-kiegel deleted the refactor-simplify branch December 26, 2015 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants