Bump tailscale dependency #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a security patch notice on my tailscale dashboard while tinkering on my
setecdeployment, so I bumped the tailscale dependency to the latest release and confirmed that works fine.Additional discussion: this patch originally added support for configuring what tags to advertise, which is now supported in the updated library. However, I kept getting errors from the node registration about the authkey not being allowed to do that, even if I select the same set of tags when creating the authkey. I'm not sure what the intended workflow for this is, but the correct tags do get advertised if I select them when creating the authkey and don't configure them when creating the
tsnet.Server. 🤷