elixir: factor out helpers and type conversions#275
Open
npry wants to merge 1 commit into
Open
Conversation
npry
marked this pull request as ready for review
July 9, 2026 10:00
npry
force-pushed
the
npry/ex.refactor-helpers
branch
from
July 9, 2026 11:57
9fad277 to
77d055b
Compare
npry
force-pushed
the
npry/ex.refactor-helpers
branch
from
July 16, 2026 15:08
77d055b to
36df659
Compare
Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Iea7ee490d17c39931cc3ac3187d9b2336a6a6964
npry
force-pushed
the
npry/ex.refactor-helpers
branch
from
July 17, 2026 06:13
36df659 to
d000fe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old but still-relevant change that was part of #172.
Refactors a bunch of helpers and types out of the root
lib.rsand makes better use ofrustler::Decoder, which e.g. lets us takeErlIpandIpOrSelfliterally as nif arguments. Also switches to useNifResultin a number of places, which automatically handles result wrapping to{:ok, term} | {:err, term}rather than the manual approach we had been using before.