ts_runtime: wait to build routes until derp map is populated#282
Open
dylan-tailscale wants to merge 1 commit into
Open
ts_runtime: wait to build routes until derp map is populated#282dylan-tailscale wants to merge 1 commit into
dylan-tailscale wants to merge 1 commit into
Conversation
Signed-off-by: Dylan Bargatze <dylan@tailscale.com>
nrc
reviewed
Jul 16, 2026
nrc
left a comment
nrc
left a comment
Contributor
There was a problem hiding this comment.
The Default impl seems fine, question about the flag though
| peer_state: Arc<PeerState>, | ||
| env: Env, | ||
| /// Prevents building routes until the first `DerpTransportMap` has been processed. | ||
| is_initialized: bool, |
Contributor
There was a problem hiding this comment.
Could derp_transport_map be an Option rather than adding a bool here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents
RouteUpdater::build_routes()from attempting to build routes to peers until it's received at least oneDerpTransportMapmessage.Also adds a
Defaultimplementation toPeerRoutesInner. This seems slightly cleaner to me, but open to changing it back to separate vars, mostly looking for feedback if what I've done is unidiomatic.Closes #279.