Handle an async design system #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
commented
Aug 9, 2024
| let design = tailwindcss.__unstable__loadDesignSystem(resolved.css) as DesignSystem | ||
| let design: DesignSystem = await tailwindcss.__unstable__loadDesignSystem(resolved.css, { | ||
| loadPlugin() { | ||
| return () => {} |
There was a problem hiding this comment.
We're intentionally not handling @plugin here — this PR is purely to make sure alpha 19 doesn't break in intellisense. That support will be done in a separate PR.
RobinMalfait
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v4 we've made compile async as well as
__unstable_loadDesignSystemand we need to handle that in intellisense.