Skip to content

Lookup variables in the CSS theme #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Nov 5, 2024

@thecrypticace thecrypticace force-pushed the feat/v4-theme-key-lookups branch from d43141a to 1878ae6 Compare November 5, 2024 19:51
@thecrypticace thecrypticace marked this pull request as ready for review November 5, 2024 19:51
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but agree this needs to be tested as you pointed out 👍

Base automatically changed from fix/v4-invalid-theme-keys to main November 8, 2024 13:46
@thecrypticace thecrypticace force-pushed the feat/v4-theme-key-lookups branch from afd6906 to 814541c Compare November 8, 2024 14:47
@thecrypticace thecrypticace merged commit 3014df5 into main Nov 8, 2024
@thecrypticace thecrypticace deleted the feat/v4-theme-key-lookups branch November 8, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants