Skip to content

Reload v4 design system when dependencies change #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

thecrypticace
Copy link
Contributor

I noticed that editing imported CSS files, plugins, and configs in v4 the config wasn't reloading. This PR fixes that by making sure we reload when any of them change.

Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super relevant for this PR, but looks like CI is failing on the main branch.

I also couldn't get pnpm run build to work in tailwindcss-intellisense/packages/vscode-tailwindcss so I might be missing something:

❯ pnpm run build
(node:59143) ExperimentalWarning: CommonJS module /Users/robin/Library/pnpm/global/5/.pnpm/[email protected]/node_modules/pnpm/dist/pnpm.cjs is loading ES Module /Users/robin/Library/pnpm/global/5/.pnpm/[email protected]/node_modules/supports-color/index.js using require().
Support for loading ES Module in require() is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

> [email protected] build /Users/robin/github.com/tailwindlabs/tailwindcss-intellisense/packages/vscode-tailwindcss
> pnpm run check && pnpm run clean && pnpm run _esbuild --minify && move-file dist/server.js dist/tailwindServer.js && move-file dist/cssServer.js dist/tailwindModeServer.js


> [email protected] check /Users/robin/github.com/tailwindlabs/tailwindcss-intellisense/packages/vscode-tailwindcss
> tsc --noEmit

../../node_modules/.pnpm/[email protected]/node_modules/enhanced-resolve/types.d.ts:15:11 - error TS2304: Cannot find name 'AbortSignal'.

15  signal?: AbortSignal;
             ~~~~~~~~~~~

../../node_modules/.pnpm/[email protected]/node_modules/jiti/lib/types.d.ts:247:24 - error TS2304: Cannot find name 'URL'.

247   parentURL?: string | URL;
                           ~~~

../tailwindcss-language-server/src/lib/env.ts:14:19 - error TS2349: This expression is not callable.
  Type '{}' has no call signatures.

14     return Module.isBuiltin(id)
                     ~~~~~~~~~

../tailwindcss-language-server/src/util/resolve.ts:11:43 - error TS2345: Argument of type 'typeof import("fs")' is not assignable to parameter of type 'BaseFileSystem'.
  Type 'typeof import("fs")' is not assignable to type 'FileSystem'.
    Types of property 'readFile' are incompatible.
      Type 'typeof readFile' is not assignable to type 'ReadFile'.
        Types of parameters 'options' and 'options' are incompatible.
          Type '"ascii" | "utf8" | "utf-8" | "utf16le" | "ucs2" | "ucs-2" | "base64" | "latin1" | "binary" | "hex" | "utf-16le" | "base64url" | ({ encoding: BufferEncoding; flag?: string; } & Abortable)' is not assignable to type '{ encoding?: null; flag?: string; }'.
            Type '{ encoding: BufferEncoding; flag?: string; } & Abortable' is not assignable to type '{ encoding?: null; flag?: string; }'.
              Types of property 'encoding' are incompatible.
                Type 'BufferEncoding' is not assignable to type 'null'.
                  Type '"ascii"' is not assignable to type 'null'.

11     fileSystem: new CachedInputFileSystem(fs, 4000),
                                             ~~


Found 4 errors in 4 files.

Errors  Files
     1  ../../node_modules/.pnpm/[email protected]/node_modules/enhanced-resolve/types.d.ts:15
     1  ../../node_modules/.pnpm/[email protected]/node_modules/jiti/lib/types.d.ts:247
     1  ../tailwindcss-language-server/src/lib/env.ts:14
     1  ../tailwindcss-language-server/src/util/resolve.ts:11
 ELIFECYCLE  Command failed with exit code 2.

Comment on lines +1064 to +1065
// TODO: Need to verify how well this works across various editors
// updateCapabilities()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something you want to do before this PR is merged?

Copy link
Contributor Author

@thecrypticace thecrypticace Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I left this as a note for me to check soon but I don't want this to block the actual fix.

@thecrypticace
Copy link
Contributor Author

Not super relevant for this PR, but looks like CI is failing on the main branch.

I'm not seeing this…

I also couldn't get pnpm run build to work in tailwindcss-intellisense/packages/vscode-tailwindcss so I might be missing something:

… or this.

Maybe node version? 🤔

@thecrypticace
Copy link
Contributor Author

(we figured it out, node_modules folder in the users folder caused a problem)

@thecrypticace thecrypticace merged commit 3682d72 into main Jan 10, 2025
@thecrypticace thecrypticace deleted the feat/v4-reload-on-imported-css-change branch January 10, 2025 14:52
@alxNoComment
Copy link

#1120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants