Skip to content

Improve CSS completions #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 5, 2025
Merged

Improve CSS completions #1165

merged 6 commits into from
Feb 5, 2025

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Feb 4, 2025 •
edited
Loading

  • Support property and variable completions inside @utility (behave like a style rule)
  • Support style-rule like completions inside @custom-variant
  • Support style-rule like completions inside @variant
  • Make sure @slot isn't considered an unknown at-rule

Fixes #1146

@thecrypticace thecrypticace marked this pull request as ready for review February 4, 2025 20:24
philipp-spiess
philipp-spiess reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @variant and we gucci

@thecrypticace thecrypticace merged commit adc3769 into main Feb 5, 2025
@thecrypticace thecrypticace deleted the fix/better-css-completions branch February 5, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

@RobinMalfait RobinMalfait Awaiting requested review from RobinMalfait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v4] @utility directive's content css doesn't have intellisense for css properties
2 participants
@thecrypticace @philipp-spiess