Skip to content

Clarify how the configFile option works with v4 #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Feb 4, 2025

This updates the readme to detail how the tailwindCSS.experimental.configFile option is meant to be used with v4.

This PR also does two additional things:

  • Makes sure this works even with the bundled / fallback version of v4
  • Adds tests verifying this behavior

@thecrypticace thecrypticace marked this pull request as ready for review February 4, 2025 20:23
@thecrypticace
Copy link
Contributor Author

cc @reinink would you mind taking a peek at the readme changes?

Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fix LGTM, I think the changelog change is fine too but would still appreciate @reinink giving it a 👀

Copy link
Member

@reinink reinink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided some possible README tweaks 👍

@thecrypticace thecrypticace requested a review from reinink February 5, 2025 14:00
@thecrypticace thecrypticace force-pushed the feat/clarify-config-file-option branch from f4a5599 to f4225ce Compare February 5, 2025 15:07
@thecrypticace thecrypticace merged commit 22438ce into main Feb 5, 2025
@thecrypticace thecrypticace deleted the feat/clarify-config-file-option branch February 5, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants