Fix detection when project contains stylesheets that import the "main" stylesheet #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
thecrypticace
force-pushed
the
feat/fix-root-detection
branch
from
57033b5 to
63c4b08
Compare
philipp-spiess
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1217
This issue kinda reveals that the entire detection around "project roots" or "root stylesheets" needs to be rethought because files at the top of a CSS graph may not actually be the intended stylesheet — especially when
@referenceis used. But… like anything… they also might be.In the meantime we'll "prefer" files we can detect as definite root stylesheets before trying other files.