Implement better calc(…) evaluation for completions and equivalents
#1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The types change is basically because the types only exist for the ESM exports for those packages. NodeNext/Node16 resolution works for ESM but not for CJS which is maybe the issue. The language isn't currently declared as "type": "module" though it actually should be b/c that's the bundled format. I'll make that change when we do the node version bump + service refactor. |
philipp-spiess
approved these changes
Apr 23, 2025
Base automatically changed from
fix/class-functions-hover-in-script-tags
to
main
April 23, 2025 14:51
thecrypticace
force-pushed
the
fix/better-calc-evaluation
branch
from
4aaf5fd to
5c1a316
Compare
thecrypticace
force-pushed
the
fix/better-calc-evaluation
branch
from
5c1a316 to
cfa251d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314
Hovers:
Completions:
