Skip to content

Update default file exclusions #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2025
Merged

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Apr 25, 2025

IntelliSense, by default, ignores files for:

  • Version control (.git, .hg, .svn)
  • NPM (node_modules)

I'm adding three more groups to this:

  • Python virtual environment folders (.venv, venv)
  • Yarn v2+ metadata & caches (.yarn)
  • some build caches (.next, .turbo, .parcel-cache, __pycache__)

Discovered that we should update these when triaging #1312 (that one was specifically about python virtual envs)

@thecrypticace thecrypticace force-pushed the feat/updated-default-excludes branch from d9b63e5 to 0933d82 Compare May 8, 2025 14:48
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

To we want to somehow take the @source information into account in case you do want to enable intellisense in one of these folders?

I'm thinking of the Laravel folks that use vendor (we are not excluding vendor in this case so not an issue for them. Just thinking out loud here)

@thecrypticace
Copy link
Contributor Author

To we want to somehow take the @source information into account in case you do want to enable intellisense in one of these folders?
I'm thinking of the Laravel folks that use vendor (we are not excluding vendor in this case so not an issue for them. Just thinking out loud here)

For now, I'm thinking not. This list shouldn't ever contain things like vendor, build, cache, etc… because those could be actual names for folders that aren't caches.

This not only affects whether or not files can show hovers/completions/diagnostics but also the discovery of CSS files in the first place.

@thecrypticace thecrypticace merged commit 03ad23d into main May 8, 2025
12 checks passed
@thecrypticace thecrypticace deleted the feat/updated-default-excludes branch May 8, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants