Add CSS Columns Specification [WIP] #541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 23, 2018 23:25
Closed
|
Updated all classes to use |
|
Hey really sorry to not have addressed this at all until now but I think this would be better suited for a plugin right now. Really appreciate the contribution either way and sorry again for not acknowledging the PR sooner. |
|
Definitely. After building 20 or so sites with tailwind I only used this once. So a plug-in is definitely a better fit. |
|
I published a plugin while ago inspired by your comments on #540. Links just for reference, in case someone lands here and doesn't look into the related issues: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a handful of new utilities covering the css column spec. This is a work in progress and just a proposal on what utilities could be added to cover css columns.
Added Utilities For
As of now these are all separated into their own generators but can easily be converted into one generator to clean it up.
Config Updates
There are some updates to the default config for column-count, column-width, column-rule-wdith, and column-rule-colors, however all of these except for column count could theoretically pull from other config options. The three column rule specifications are essentially the same as border so we could use those same settings. Column Width could pull from the width settings as well.
As Css columns is not the most commonly used system in css these generators could be set to false in the default config, but I do think they are useful for their purpose and can be useful in the Tailwind Core.
Progrees
Topics of Discussion