Fix types for CJS projects using TypeScript NodeNext/Node16

[frehner]

Followup to #267 and #275

Tested both ESM and CJS projects (by modifying the example package) and this works.

[changeset-bot]

🦋 Changeset detected

Latest commit: 18f3d2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@ladle/react	Patch
example	Patch
test-addons	Patch
test-config	Patch
test-config-ts	Patch
test-css	Patch
test-decorators	Patch
test-flow	Patch
playwright	Patch
test-programmatic	Patch
test-provider	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ladle	✅ Ready (Inspect)	Visit Preview	Oct 9, 2022 at 7:05PM (UTC)

[frehner]

cp won't work across platforms (e.g. windows) - would you like me to include something like https://www.npmjs.com/package/cpy-cli so that it does, or are you ok with this as it will generally only run in CI/CD processes?

[tajo]

yea, this doesn't need to be x-platform

[frehner]

Frustrating:

The Stackblitz appears to still not be working.

But in a real project, I can update to the latest next version and test both ESM and CJS and they work.

I'm not sure why the Stackblitz isn't working... but it does seem to work in the "real world."

Hmm.

[frehner]

And just retested it from the example package and it works there too. Hm.

At this point I think it may be a Stackblitz thing more than anything?

[tajo]

@frehner tried to publish the stable version, a bit strange error: https://github.com/tajo/ladle/actions/runs/3229204374/jobs/5286226320#step:8:12

[frehner]

@tajo Ah, I think that happened because we generated the type files for publishing the normal version, and then tried to generate the type files again to publish the next version.

Hmmm, thoughts?

[tajo]

Ah yea, that makes sense

[frehner]

Do you want me to add additional logic to try and fix this? Do you have an idea of how you would like it done?

[tajo]

Do you want me to add additional logic to try and fix this?

Help is always appreciated!

Do you have an idea of how you would like it done?

I think it still makes sense to publish next version together with the stable version (you never want to end up with outdated version after installing @next).