Skip to content

Elixir 1.1 support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Elixir 1.1 support #2

wants to merge 4 commits into from

Conversation

mhib
Copy link

@mhib mhib commented Oct 3, 2015

No description provided.

@lpil
Copy link

lpil commented Oct 31, 2015

👍

1 similar comment
@mkaput
Copy link

mkaput commented Oct 31, 2015

👍

@lpil
Copy link

lpil commented Oct 31, 2015

Since takscape seems to be AWOL, maybe we should fork this project, add 1.1 support, and then upload it on hex as a new package. I could do this. What do we think?

@@ -155,11 +155,36 @@ defmodule Array do

@doc """
Gets the value of entry `idx`. If `idx` is not a nonnegative integer, or if the array has
fixed size and `idx` is larger than the maximum index, the call raises `ArgumentError`.
fixed size and `idx` is larger than the maximum index, the call returns :error
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the use of error tuples now.

@mhib
Copy link
Author

mhib commented Nov 26, 2015

I'm ok with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants