Expand r support #2115
Expand r support #2115
Conversation
|
We are intentionally moving away from state as a prefix in community. Could you instead use something else for the na commands? Based on a quick google search, those are r keywords. If that is correct, could you move those over to keyword support? |
|
oh really? I hadn't realised we were moving away, I can migrate the lot to more preferred terms. |
|
The issue with state is that state was originally intended for referring to statements (such as state while) but unfortunately morphed into the default prefix. If those are in fact keywords, you could move them to a |
| language: vimscript | ||
| - | ||
| "$0 | ||
| " $0 |
There was a problem hiding this comment.
Please split this out into a separate PR since it has nothing to do with R.
There was a problem hiding this comment.
that's true, but is it really necessary? This change is tiny
There was a problem hiding this comment.
Yes :) The PR will also be tiny.
| state na: insert("NA") | ||
| state na character: insert("NA_character_") | ||
| state na real: insert("NA_real_") | ||
| state na complex: insert("NA_complex_") | ||
| state na integer: insert("NA_integer_") |
There was a problem hiding this comment.
From the Community Backlog Session — since all of these are reserved words/keywords in the R language, we should switch these over to keywords. Please add a deprecation for "state na".
3 participants
Also a tiny correction to the vimscript comment - add the missing space after "