Skip to content

Fix help active context detection #2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FireChickenProductivity wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Fix help active context detection #2119

FireChickenProductivity wants to merge 16 commits into from

Conversation

@FireChickenProductivity
Copy link
Contributor

@FireChickenProductivity FireChickenProductivity commented Jan 21, 2026 •
edited
Loading

Make active context detection consistent in the help system. This change makes the cached active context list match the commands that help active will show. While I was here, I simplified the refresh_context_command_map function a little.

@FireChickenProductivity FireChickenProductivity marked this pull request as ready for review January 22, 2026 18:35
nriley
nriley requested changes Jan 31, 2026
View reviewed changes
@FireChickenProductivity
Copy link
Contributor Author

FireChickenProductivity commented Feb 2, 2026

I did the requested renaming and removed the unused Override dictionary to simplify the code. Do we still want someone other than me to test drive this before merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nriley nriley Awaiting requested review from nriley

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FireChickenProductivity @nriley