Skip to content

Fix debendency conflicts #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix debendency conflicts #296

merged 1 commit into from
Nov 15, 2022

Conversation

Elishtar
Copy link
Contributor

@Elishtar Elishtar commented Nov 10, 2022 •
edited
Loading

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:

Closes #297

@Elishtar Elishtar requested a review from ArtDu November 14, 2022 05:57
ArtDu
ArtDu requested changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@ArtDu ArtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump testcontainers-java-tarantool to 0.5.2 and add some words to changelog

@ArtDu
Copy link
Contributor

ArtDu commented Nov 14, 2022

Changelog in the following format

# Changelog

## [Unreleased]
- Add dependency management
- Bump snakeyaml to 1.33
- Bump junit-jupiter to 5.9.0
- Bump logback-classic to 1.2.11

And squash commits to the one to see the result before merging like I've done it here:
image

@Elishtar Elishtar force-pushed the fix_debendency_conflicts branch 3 times, most recently from 1cf6dbb to 25a3333 Compare November 14, 2022 10:04
@ArtDu ArtDu force-pushed the fix_debendency_conflicts branch from aca9ec2 to 3dd98b8 Compare November 15, 2022 13:17
@ArtDu ArtDu merged commit adb8641 into master Nov 15, 2022
@ArtDu ArtDu deleted the fix_debendency_conflicts branch November 15, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtDu ArtDu ArtDu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dependency management
2 participants
@Elishtar @ArtDu