Skip to content

Use netty part dependencies instead of netty-all #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

Use netty part dependencies instead of netty-all #318

merged 1 commit into from
Dec 6, 2022

Conversation

Elishtar
Copy link
Contributor

@Elishtar Elishtar commented Dec 5, 2022 •
edited
Loading

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:

Closes #295

@Elishtar Elishtar requested a review from ArtDu December 5, 2022 16:28
ArtDu
ArtDu approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@ArtDu ArtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good if you write Closes #295 at the end of the commit body massage

@Elishtar Elishtar merged commit f639895 into master Dec 6, 2022
@Elishtar Elishtar deleted the use_netty_part_dependencies branch December 6, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtDu ArtDu ArtDu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use netty part dependencies instead of netty-all
2 participants
@Elishtar @ArtDu