-
Notifications
You must be signed in to change notification settings - Fork 12
Add toString in tarantool proxy entities #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
@Override | ||
public String toString() { | ||
return "TarantoolResultImpl{" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай единообразно будем использовать String.format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced it with classic concat everywhere. We are building a perfomance software :)
https://stackoverflow.com/a/1281651

|
||
@Override | ||
public String toString() { | ||
return "TarantoolFieldMetadataImpl{" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай единообразно будем использовать String.format
before
after
I haven't forgotten about:
Related issues:
Closes #406