Skip to content

Fix initiating migrations on a replica #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2022
Merged

Fix initiating migrations on a replica #57

merged 2 commits into from
Feb 18, 2022

Conversation

sharonovd
Copy link
Contributor

Closes #56

@Totktonada Totktonada self-requested a review February 17, 2022 17:46
Totktonada
Totktonada reviewed Feb 17, 2022
View reviewed changes
@Totktonada
Copy link
Member

I understood that there are some nuances about order of applying a new schema / mirating data and asked Dmitry to reveal more info about the problem.

Totktonada
Totktonada approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Totktonada Totktonada merged commit 1065f71 into master Feb 18, 2022
@Totktonada Totktonada deleted the fix-replica branch February 18, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrations may fail if started from replica
2 participants
@sharonovd @Totktonada