Skip to content

Serialisation RFC #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 29, 2019
Merged

Serialisation RFC #182

merged 9 commits into from
Mar 29, 2019

Conversation

CjS77
Copy link
Contributor

@CjS77 CjS77 commented Mar 25, 2019 •
edited
Loading

Description

This document describes the message serialisation formats for message payloads used in the Tari network.

Motivation and Context

There are several different user and message types that will need to communicate over the Tari network. These messages need to be converted into a format that can be sent over the wire and/or be read and processed by humans.

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch
  • I ran cargo-fmt --all before pushing
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@CjS77 CjS77 added the review label Mar 25, 2019
@CjS77
Copy link
Contributor Author

CjS77 commented Mar 25, 2019

Test fails due to rust-lang/mdBook#891

neonknight64
neonknight64 reviewed Mar 26, 2019
View reviewed changes
neonknight64
neonknight64 reviewed Mar 26, 2019
View reviewed changes
neonknight64
neonknight64 reviewed Mar 26, 2019
View reviewed changes
SWvheerden
SWvheerden reviewed Mar 26, 2019
View reviewed changes
@CjS77 CjS77 changed the title WIP: Serialisation RFC Serialisation RFC Mar 29, 2019
sdbondi
sdbondi reviewed Mar 29, 2019
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Having partially written a message type for comms, the trait will give me exactly what I need

sdbondi
sdbondi approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@CjS77 CjS77 merged commit be1c63a into development Mar 29, 2019
@CjS77 CjS77 removed the review label Mar 29, 2019
@CjS77 CjS77 deleted the serialization branch March 29, 2019 08:28
@CjS77 CjS77 mentioned this pull request Apr 3, 2019
Closed
CjS77 pushed a commit that referenced this pull request Jun 14, 2022
@tarnas14
Merge pull request #182 from Altalogy/launchpad/feature/40_43/persist…
b6388a9 
…_store

feat: persist redux store in local storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden left review comments

@neonknight64 neonknight64 neonknight64 left review comments

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CjS77 @sdbondi @SWvheerden @neonknight64