Skip to content

Closes #43 Decode JSON response as UTF-8 by default #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

walsha2
Copy link
Contributor

@walsha2 walsha2 commented Nov 19, 2023

Add a universal _jsonDecode method to handle the JSON decode logic. Right now it just uses a default utf8.decode decoder for everything, but in order to be robust we should probably add some charset checking logic in case there is an alternate charset defined from the server response. Adding this global function makes it easy to define this logic in one place.

@walsha2 walsha2 enabled auto-merge (squash) November 19, 2023 22:38
@walsha2 walsha2 merged commit f2785e1 into main Nov 19, 2023
@walsha2 walsha2 deleted the 43-utf-decode branch November 19, 2023 22:39
@walsha2 walsha2 changed the title Closes #34 Decode JSON response as UTF-8 by default Closes #43 Decode JSON response as UTF-8 by default Nov 19, 2023
@walsha2 walsha2 linked an issue Nov 19, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support UTF-8 characters (e.g. Hebrew)
1 participant